Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-xhr): Only modify the responseType if it was changed #363

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

offirgolan
Copy link
Collaborator

Description

Modifying the responseType for synchronous requests is not allowed. Since we really just need to override blob or arraybuffer to arraybuffer and not default it to text, I moved the logic into an if statement which should naturally add support back to synchronous requests.

Motivation and Context

Resolves #356.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan added bug 🐞 Something isn't working 📦 adapter-xhr labels Sep 7, 2020
@offirgolan offirgolan merged commit cff4e2d into master Sep 7, 2020
@offirgolan offirgolan deleted the fix-xhr-sync-bug branch September 7, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working 📦 adapter-xhr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XMLHttpRequest response type cannot be changed for synchronous requests
2 participants