Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Compute order based on id and recording name #342

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Jun 4, 2020

Description

Compute the request's order based on its id as well as the recording id it will be accessed from.

Motivation and Context

Resolves #340.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan added bug 🐞 Something isn't working 📦 core labels Jun 4, 2020
@offirgolan offirgolan requested a review from jasonmit June 4, 2020 23:44
@offirgolan
Copy link
Collaborator Author

@jasonmit thoughts on this? This is potentially a breaking change since we are tweaking the way order is being calculated.

@jasonmit
Copy link
Contributor

jasonmit commented Jun 5, 2020

@jasonmit thoughts on this? This is potentially a breaking change since we are tweaking the way order is being calculated.

Agreed, changing existing functionality should be a breaking a change and I'm fine with it.

@offirgolan offirgolan merged commit 42004d2 into master Jun 5, 2020
@offirgolan offirgolan deleted the compute-order-based-on-recording-id branch June 5, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working 📦 core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocking server's downstream requests during parallel functional tests
2 participants