Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persister): Cache recordings #31

Merged
merged 3 commits into from
Jun 21, 2018
Merged

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Jun 21, 2018

I realized that we don't really need a findRecordingEntry method since we fetch the entire recording when persisting anyways. We might as well cache the recording on the first find and use that to locally find entries. This should greatly reduce the amount of network requests we make as well as reduce the amount of times we read from disk.

  • Cache recordings and bring findRecordingEntry into the base persister.
  • Bust the cache when saving & deleting.

Cache recordings and bring `findRecordingEntry` into the base persister.
@offirgolan offirgolan requested a review from jasonmit June 21, 2018 06:21
@offirgolan offirgolan merged commit a04d7a7 into master Jun 21, 2018
@offirgolan offirgolan deleted the u/offirgolan/persister-cache branch June 21, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants