Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom placeholder view to be provided via props. #2

Open
ognen opened this issue Apr 7, 2017 · 1 comment
Open

Allow for custom placeholder view to be provided via props. #2

ognen opened this issue Apr 7, 2017 · 1 comment

Comments

@ognen
Copy link
Member

ognen commented Apr 7, 2017

The usage should be:

<TweetView tweetId={323} placeholder={<Placeholder />} />

alternatively

<TwieetView tweetId={332} renderPlaceholder={() => <Placeholder />} />
@gorjanz
Copy link
Contributor

gorjanz commented May 9, 2017

Right now, the Placeholder view is managed from the native module - VAMP-924 / VAMP-923
@ognen Can you please support @cristisamoila and @andianton in implementing this issue, because I don't have enough experience in this area. Also, you can decide whether the native placeholder view is enough for start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants