Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap RNTwitterKit with a plain JS view class and provide propTypes. #1

Open
ognen opened this issue Apr 7, 2017 · 1 comment
Open

Wrap RNTwitterKit with a plain JS view class and provide propTypes. #1

ognen opened this issue Apr 7, 2017 · 1 comment

Comments

@ognen
Copy link
Member

ognen commented Apr 7, 2017 •
edited
Loading

The RNTwitterKit native module should be wrapped with a pure JS react component called TweetView.

This allows propTypes to be declared and documented in a way that is understandable for the JS users
of the library.

TweetView should be the default export of the index.js.

See https://facebook.github.io/react-native/docs/native-components-ios.html#properties
@andianton
Copy link
Contributor

  • done in iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ognen @andianton