Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenancy to Provider #8501

Closed
polski-g opened this issue Jan 31, 2022 · 7 comments
Closed

Add tenancy to Provider #8501

polski-g opened this issue Jan 31, 2022 · 7 comments
Labels
pending closure Requires immediate attention to avoid being closed for inactivity type: feature Introduction of new functionality to the application

Comments

@polski-g
Copy link

NetBox version

v3.1.6

Feature type

Data model extension

Proposed functionality

A new field in the Provider creation/edit pages which allows user to assign a Tenant for the Provider.
A new field in the Provider detail and list pages which lists an assigned Tenant for the Provider.

Use case

Imagine company Foobar Corp has divisions Bar and Foo. Bar and Foo might each have a separate contract with a Provider. Therefore they would each have a separate Account Number to give the support personnel at Provider if there is an outage. As of now, Netbox only allows a single Account Number field for a given Provider, regardless of how many contracts your overall Foobar Corp has.

Database changes

No response

External dependencies

No response

@polski-g polski-g added the type: feature Introduction of new functionality to the application label Jan 31, 2022
@jeremystretch
Copy link
Member

Imagine company Foobar Corp has divisions Bar and Foo. Bar and Foo might each have a separate contract with a Provider.

But there's still only one provider, irrespective of its relationship with the tenants. I assume your intent here is to duplicate the provider, with each instance assigned a different tenant, but I don't think that makes sense.

As an infrastructure tool, NetBox probably isn't the best place to store contract information. If you really need to, you could add a custom field on the tenant model to track this information.

@polski-g
Copy link
Author

polski-g commented Feb 3, 2022

But there's still only one provider

I agree, which is weird as to why NetBox is asking for Account Number in the Provider page; the Account Number would be unique per contract that the Provider signed with a company (its a number that the Provider created and assigned to you)

@jeremystretch
Copy link
Member

The account field is provided for convenience, as most organizations only have one account per provider. If you need to manage separate contracts, that should be done outside of NetBox. It wouldn't make sense to create multiple instances of the same provider.

@darkpixel
Copy link

We have hundreds of accounts numbers with Comcast. It depends on the circuit, what region it's in, if it's part of their "hierarchy account" structure, etc...

@DanSheps
Copy link
Member

DanSheps commented Feb 4, 2022

I think what you need is an "provider account" model, which I don't see adding to core but could be trivial to add as a plugin. You would use this model to tie both provider and circuits together.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Apr 6, 2022
@jeremystretch
Copy link
Member

I'm going to close this in favor of #9047, which proposes a new Account model that can be used for this purpose.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending closure Requires immediate attention to avoid being closed for inactivity type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants