Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 beta - menu enhancement request #6800

Closed
tomaskir opened this issue Jul 23, 2021 · 5 comments
Closed

v3.0 beta - menu enhancement request #6800

tomaskir opened this issue Jul 23, 2021 · 5 comments
Labels
beta Concerns a bug/feature in a beta release status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application

Comments

@tomaskir
Copy link

NetBox version

3.0

Feature type

New functionality

Proposed functionality

Menu should not close each time you change a view. It makes navigation a bit tedious. For example, when in the Racks view (and its subviews), keep the Organization section of the menu should stay extended.

Use case

Menu in 2.11 has no animations (faster navigation) and the menus groups being horizontally side-by-side makes visually identifying where things are faster - building "visual memory" for where to click to get to a particular view is quite easy due to the static positioning and each element having unique position is easier.

In 3.0, due to animations and everything being in the same vertical menu (with dynamic position due to scroll), it means you consciously have to identify where you want to click, scroll to the position, etc. As most workflows usually happen within a menu group, having it extended when you are in a view inside that menu group would help with that.

Database changes

No response

External dependencies

No response

@tomaskir tomaskir added the type: feature Introduction of new functionality to the application label Jul 23, 2021
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Jul 23, 2021
@PieterL75
Copy link
Contributor

I'm not a fan of the new side menu either... Those to dropdown menu have a much faster to navigate and don't mess a round with the position you have to click...
The side menu also takes up space. Most output are tables, where we need the full width of the screen to display..

@binaryoverload
Copy link

I do like the new menu but I do agree that it does take up a fair bit of space. Perhaps a good solution to this is to make the sidebar collapsible 🤔

@jeremystretch
Copy link
Member

The tricky part is passing state to the menu, to know which section (if any) should be expanded. We actually did this in much older versions of NetBox to highlight the "active" menu button, but decided it wasn't worth the effort to keep up. I'd like to come up with something a bit more clever than manually specifying the active menu section under each view.

I'm not a fan of the new side menu either...

FWIW I ran a very informal Twitter poll where people preferred a sidebar to a top menu roughly 2:1. I imagine it will start to feel more familiar after a bit of use.

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Jul 29, 2021
@thatmattlove
Copy link
Contributor

FYI, this is fixed as of 3752cb3. The nav menu is now collapsible and determines the state of the current page and highlights the appropriate menu item accordingly.

@PieterL75
Copy link
Contributor

What I don't like about sidebars, is that menu Items get dropped off the screen.
If you open 'device's, then you have to close it again before you can go to 'other/reports'.
No, this is not an improvement.

Navigation has to be quick without extra clicks to find your way

I can understand that the sidebar remains, but that the submenu pops out to the right, as it poped out to the bottom with the top menu. Then the navigation will be more slick

Pieter

@Jackbennett Jackbennett mentioned this issue Aug 10, 2021
14 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants