Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve two minor UI inconsistencies related to Virtual Interfaces #6740

Closed
mabroze opened this issue Jul 11, 2021 · 1 comment
Closed

Improve two minor UI inconsistencies related to Virtual Interfaces #6740

mabroze opened this issue Jul 11, 2021 · 1 comment
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@mabroze
Copy link

mabroze commented Jul 11, 2021

NetBox version

v2.11.9

Feature type

New functionality

Proposed functionality

These are little more than cosmetic inconsistencies, but at the same time I reckon they are easy to fix.

Inconsistency 1

As far as I can tell, the only was to add an Interface to a VM is by opening the VM and clicking Add Interfaces. However, if manually entering the URL /virtualization/interfaces/add/ takes you to a page that lets you add an interface on an arbitrary VM. I propose

  • Adding an Add button for Virtual Interfaces to the menu (Virtualization, behind Interfaces)
  • Adding an Add button to the Virtual Interfaces page (/virtualization/interfaces/)
    The target for both buttons would be the URL mentioned above.

Inconsistency 2

Currently it is possible to import Virtual Interfaces via the menu (Virtualization, Import icon behind Interfaces). However, if you go to the Virtual Interfaces page (/virtualization/interfaces/) there is no Import button. I propose adding such a button and have it link to the same target as the menu does (/virtualization/interfaces/import/).

Use case

Slight improvement to the overall logic and structure of the UI.

Database changes

None

External dependencies

None

@mabroze mabroze added the type: feature Introduction of new functionality to the application label Jul 11, 2021
@DanSheps
Copy link
Member

We are going to pass on #1, there is no add button for DCIM interfaces page either.

#2 we can look at

@DanSheps DanSheps added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jul 15, 2021
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jul 30, 2021
@jeremystretch jeremystretch self-assigned this Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants