Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook - Interface Update - Tags #5623

Closed
cbehre opened this issue Jan 13, 2021 · 3 comments
Closed

Webhook - Interface Update - Tags #5623

cbehre opened this issue Jan 13, 2021 · 3 comments

Comments

@cbehre
Copy link

cbehre commented Jan 13, 2021

Environment

  • Python version: 3.8.5
  • NetBox version: 2.10.3

Steps to Reproduce

  1. Add webhook for interface update with default request body (not using Jinga2 template)
  2. Add Tags to an interface
  3. Save with call to webhook

Expected Behavior

All current interface tags to be included

Observed Behavior

The call to the webhook the Tags included are from the previous update to the interface

i.e. Initial state: no tags

Save adding tag_123

JSON posted to webhook has no tags included.

Save interface again with tag_123 and tag_456

JSON posted to webhook has only tag_123 included

Save interface removing all tags

JSON posted to webhook has tag_123 and tag_456 included.

@lampwins
Copy link
Contributor

Related to #5583.

This has to do with the many-to-many relationship to tags, and the Django signals based implementation of change logging and webhooks.

@stale
Copy link

stale bot commented Mar 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Mar 5, 2021
@jeremystretch
Copy link
Member

This is likely addressed by #5913 in v2.11.

@jeremystretch jeremystretch removed the pending closure Requires immediate attention to avoid being closed for inactivity label Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants