Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default table configuration #5576

Closed
TomGrozev opened this issue Jan 4, 2021 · 7 comments
Closed

Change default table configuration #5576

TomGrozev opened this issue Jan 4, 2021 · 7 comments
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application

Comments

@TomGrozev
Copy link
Contributor

Environment

  • Python version: 3.7.3
  • NetBox version: 2.10.x

Proposed Functionality

Be able to set in the admin panel the default table configuration for columns for all users. This would be on a per model basis, e.g. virtual machines could have a different configuration to vlans. If a user customises the column configuration it would override the default.

Use Case

This would allow for a default view for new users without having to change the configuration. This is especially useful for custom fields in tables and hence closesly related to #5344 and #5460.

Database Changes

This could be done with a new model but would be much more efficient to simply store an ordered list in the associated model for the default configuration. Due to the database change this would likely be a candidate for 2.11.

External Dependencies

N/A

Also, I am happy to have this assigned to me.

@DanSheps
Copy link
Member

DanSheps commented Jan 5, 2021

If we went down this route, I would say it would be better to store the configuration in configuration.py. I don't think it makes sense to make a database query for each page view with a table when the query itself would be rather static.

The problem is each table has different columns so it would need to be a list in a dict or similar for this to work (just off the top of my head).

That said, we already have enough on our plate so someone would have to volunteer to own this.

@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application labels Jan 5, 2021
@jeremystretch
Copy link
Member

IMO this exceeds the reasonable ratio for developer burden to user value. If you really need a way to set default views for new users, it seems like a custom script would work just fine.

@TomGrozev
Copy link
Contributor Author

@DanSheps I believe you are right, a configuration option would actually be much better.

I will give it a go and make a PR if you assign the issue to me.

@xkilian
Copy link

xkilian commented Jan 6, 2021

I would personally love to see this go forward, as it may be more burden for devs, but for dozens of users, each having to customize their views to match company documentation/traning material is a bit of a usability problem. As I am sure most companies will make use of custom fields for various needs and should/will want to make that data more accessible. I understand that a custom script could set these values for users, so there is a workaround. Thank you once again fro the excellent work.

@exc91
Copy link

exc91 commented Jan 21, 2021

Tell me please is this feature available in release Netbox 2.10.3?
I already have installed Netbox 2.10.3 and it's really great product. But I didn't find how to make custom fields take a place to the table Devices with button Configure on a right top in my case...

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale stale bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Mar 19, 2021
@github-actions
Copy link
Contributor

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants