Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginMenuItem with permission is still clickable #5046

Closed
kuzmik opened this issue Aug 24, 2020 · 0 comments
Closed

PluginMenuItem with permission is still clickable #5046

kuzmik opened this issue Aug 24, 2020 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@kuzmik
Copy link

kuzmik commented Aug 24, 2020

Environment

  • Python version: 3.8.5
  • NetBox version: 2.9.1

Steps to Reproduce

  1. Install (or create) a plugin with a PluginMenuItem that has permissions set on it
  2. Make sure your current user doesn't have the permission that the menu item requires
  3. Click the "Plugins" drop down; the link will be grey but still have an href
  4. Click the greyed out menu item

Expected Behavior

I expected the link not to be clickable

Observed Behavior

Clicking the link directed me to the correct page. I've added the PermissionRequiredMixin to the view, and that handles it, but I assumed the greyed out link would not be clickable.

Not a huge deal since I included the mixin, but I am concerned that my readonly users will load up the page and file "why does this page say I don't have access" tickets.

@DanSheps DanSheps added status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application labels Aug 28, 2020
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation and removed type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Sep 2, 2020
@jeremystretch jeremystretch self-assigned this Sep 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

3 participants