Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of tags in Device listing #3064

Closed
candlerb opened this issue Apr 12, 2019 · 5 comments
Closed

Visibility of tags in Device listing #3064

candlerb opened this issue Apr 12, 2019 · 5 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation

Comments

@candlerb
Copy link
Contributor

Environment

  • Python version: 3.5.2
  • NetBox version: 2.5.10

Proposed Functionality

I would like to be able to see tags in the Device listing.

Possible ways to achieve this:

  • Include tags in the 'role' column
  • Make it customisable which columns are visible; I could then replace Tenant with Tags
  • View tags when hovering over device (less desirable, I really want to see them)
  • A separate devices-with-tags view
  • A checkbox on the device listing, which toggles between the normal view and the tags view (for example, Type and IP Address could be replaced with Tags when this is checked)

Use Case

I am using tags for several purposes. Seeing the set of tags for a device quickly lets me home in on devices of interest; it also lets me see quickly if there are conflicting tags which don't make sense (e.g. someone has added a tag but forgotten to remove an old one).

At the moment, the only way to see tags is (a) to drill down to individual devices one by one, or (b) to filter devices by tag (in which case, I still can't see what other tags are on a device, without drilling down)

Database Changes

None

External Dependencies

None

@candlerb
Copy link
Contributor Author

In addition: I would like to see Inventory Item tags in the Inventory listing (/dcim/devices/<pk>/inventory/)

At the moment you can't see the tags unless you drill down to individual items, and the only way to filter inventory items by tag (AFAICT) is to browse to /extras/tags/<name>/ and look for tagged inventory items

@jeremystretch
Copy link
Member

I'd like to do this, but realistically, the only we can accommodate tags in object list display is to switch to a multi-row object representation. This would allow us to display object fields on one line and tags on another.

Currently, object lists are rendered as a simple HTML table, which each object in the list corresponding to a single row in the table. We would need to extend this to either a) use multiple rows to represent each object, or b) embed a smaller table/div structure within each row. Neither approach is likely to work well with django-tables2. Need to dig into this further.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jun 24, 2019
@Armadill0
Copy link

Armadill0 commented Jul 26, 2019

I'm quite interested in this because this would also be very helpful for the ip-addresses listing (/ipam/ip-addresses/ and /ipam/prefixes//ip-addresses/).

Use case: Tagging an ip address within a prefix e.g. as "gateway" to be able to use those information on our servers for the network setup. But the information is currently only shown in the IP address detail page which makes it annoying to check the prefix if a gateway has already been defined.

Should I open another feature request for that?

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 13, 2019
@netbox-community netbox-community deleted a comment from fallenfuzz Dec 13, 2019
@netbox-community netbox-community deleted a comment from arjenvri Dec 13, 2019
@jeremystretch
Copy link
Member

Reminder: Please use 👍 or 👎 on the issue to indicate support or the lack thereof. Redundant comments will be deleted.

@jeremystretch jeremystretch self-assigned this May 6, 2020
@jeremystretch
Copy link
Member

With #492 in place, we can now add a "Tags" column to the relevant tables, which can be toggled on and off as the user desires. For particularly large tables, such as the devices table, it is assumed the user will hide uninteresting columns to make room if there is a large number of tags.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation
Projects
None yet
Development

No branches or pull requests

3 participants