Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new custom Tag model a Changelog model #2926

Closed
lampwins opened this issue Feb 22, 2019 · 1 comment
Closed

Make new custom Tag model a Changelog model #2926

lampwins opened this issue Feb 22, 2019 · 1 comment
Assignees
@lampwins
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v2.6

Comments

@lampwins
Copy link
Contributor

Environment

  • Python version: 3.7
  • NetBox version: develop-2.6

Proposed Functionality

In 2.6, NetBox migrates to use its own custom Tag model in place of the vanilla taggit model. In line with this change, the new Tag model should be made to be a Changelog model.

Use Case

Most all models in NetBox carry with them a changelog and since we now control the Tag model, this addition is trivial.

Database Changes

Tag will subclass ChangeLoggedModel and thus gain created and last_updated fields.

External Dependencies

None
@lampwins lampwins added this to the v2.6 milestone Feb 22, 2019
@lampwins lampwins added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Feb 22, 2019
@lampwins lampwins self-assigned this Feb 22, 2019
@lampwins
Copy link
Contributor Author

Implemented in the develop-2.6 branch.

@jeremystretch jeremystretch mentioned this issue Jun 20, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lampwins lampwins

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v2.6
Development

No branches or pull requests
1 participant
@lampwins