Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites fields in generated API have incorrect type #2576

Closed
dje opened this issue Nov 9, 2018 · 0 comments
Closed

Sites fields in generated API have incorrect type #2576

dje opened this issue Nov 9, 2018 · 0 comments
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application type: documentation A change or addition to the documentation

Comments

@dje
Copy link

dje commented Nov 9, 2018

Environment

  • Python version: 3.6.4
  • NetBox version: v2.4.8-dev

Steps to Reproduce

Visit /api/docs/ and then select the GET /dcim/sites API endpoint. In the Responses section you'll see count_prefixes and all the count_ fields have a string type.

Expected Behavior

Since the JSON response for these fields are integer this should be an integer type in the generated API.

Observed Behavior

The JSON response is an integer for these fields, but the generated types are string. This causes generated clients trouble.
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application type: documentation A change or addition to the documentation status: accepted This issue has been accepted for implementation labels Nov 9, 2018
@jeremystretch jeremystretch mentioned this issue Dec 7, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dje @jeremystretch