Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox to assign OOB on IP address creation #17889

Closed
remchuk opened this issue Oct 29, 2024 · 3 comments · Fixed by #18057
Closed

Checkbox to assign OOB on IP address creation #17889

remchuk opened this issue Oct 29, 2024 · 3 comments · Fixed by #18057
Assignees
Labels
complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@remchuk
Copy link

remchuk commented Oct 29, 2024

NetBox version

v3.6.6

Feature type

New functionality

Triage priority

N/A

Proposed functionality

This is a duplicate of #14594.

I propose adding a checkbox labeled "Make this the Out-of-band IP for a device, just as we have with "Make this the Primary IP"

Use case

It a small change in favor of QoL.
This will save us a lot of time and double work.
I allows a much better work with bulk editing when it comes to a lot of IP Addresses.

Database changes

No response

External dependencies

No response

@remchuk remchuk added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Oct 29, 2024
@bctiemann
Copy link
Contributor

I agree this seems like a good addition, though I would note that the "make primary IP" checkbox isn't a simple BooleanField; it triggers a code path of creating a primary_ip4 and/or primary_ip6 relation to the IPAddress when saving the Interface. It would need to be changed on VMInterface as well (probably handled in the BaseInterface class).

I'll mark it as "low complexity" since there's a pattern to follow although there are more changes necessary than might meet the eye.

@bctiemann bctiemann added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Oct 31, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch
Copy link
Member

@pl0xym0r could you leave a comment here so I can assign this FR to you please?

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 9, 2024
@pl0xym0r
Copy link
Contributor

pl0xym0r commented Dec 9, 2024

fixed by #18057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Requires minimal effort to implement netbox status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants