Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yarn packages #16712

Closed
arthanson opened this issue Jun 24, 2024 · 3 comments
Closed

Upgrade yarn packages #16712

arthanson opened this issue Jun 24, 2024 · 3 comments
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@arthanson
Copy link
Collaborator

Proposed Changes

Update yarn js packages to latest (typescript, esbuild, eslint...) using yarn update --latest

Justification

from dev documentation (https://netboxlabs.com/docs/netbox/en/stable/development/web-ui/) it says to run yarn update --latest doing this currently breaks the build / validation. The update to typescript jumps a major version number and shows validation errors in tom-select:

node_modules/tom-select/src/vanilla.ts:100:39 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x09' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);
                                          ~~~

node_modules/tom-select/src/vanilla.ts:100:42 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0a' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);
                                             ~~~

node_modules/tom-select/src/vanilla.ts:100:45 - error TS1536: Octal escape sequences and backreferences are not allowed in a character class. If this was intended as an escape sequence, use the syntax '\x0c' instead.

100    _classes = _classes.trim().split(/[\11\12\14\15\40]/);

While update to eslint shows errors:

(node:84956) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use `node --trace-warnings ...` to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.5.0

/Users/arthurhanson/dev/work/netbox/netbox/project-static/.eslintrc:2
  "root": true,
        ^
@arthanson arthanson added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 24, 2024
@marsteel
Copy link
Contributor

marsteel commented Jul 3, 2024

Yes,
There is also a security finding https://security.snyk.io/package/npm/braces/3.0.2
Bump braces from 3.0.2 to 3.0.3 in /netbox/project-static #1

@alejandrohg1
Copy link

Hi did you find a way to fix this, if so how did you do it , ty so much

@jeremystretch
Copy link
Member

This will be addressed in #16245

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

4 participants