Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to turn translation off #16055

Closed
amyasnikov opened this issue May 9, 2024 · 1 comment · Fixed by #16096
Closed

Option to turn translation off #16055

amyasnikov opened this issue May 9, 2024 · 1 comment · Fixed by #16096
Assignees
@amyasnikov
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@amyasnikov
Copy link
Contributor

amyasnikov commented May 9, 2024 •
edited
Loading

NetBox version

v4.0.0

Feature type

Change to existing functionality

Proposed functionality

Since #15752 there is no way to turn localization off.

I propose to bring this feature back to users.
The simplest way is to just move USE_I18N Django setting inside configuration.py

Use case

Having one unified UI using one same language for all users may be beneficial for international teams. Consider this example: newbie NetBox user asks experienced one about the way of creating a Custom Field. If both of them see different versions of UI (due to different languages), one can't just tell another something like "go to Customization, then Custom Fields" and so on.

Database changes

No response

External dependencies

No response
@amyasnikov amyasnikov added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 9, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 10, 2024
@arthanson arthanson removed their assignment May 10, 2024
@amyasnikov
Copy link
Contributor Author

amyasnikov commented May 11, 2024 •
edited
Loading

@arthanson @jeremystretch I can make a PR if you're okay with the proposed implementation

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 12, 2024
@amyasnikov amyasnikov mentioned this issue May 12, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amyasnikov amyasnikov

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ENABLE_TRANSLATION setting to optionally turn translation off amyasnikov/netbox
3 participants
@arthanson @abhi1693 @amyasnikov