Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG UI elements background issues in dark mode #15853

Closed
jsenecal opened this issue Apr 25, 2024 · 2 comments
Closed

SVG UI elements background issues in dark mode #15853

jsenecal opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@jsenecal
Copy link
Contributor

jsenecal commented Apr 25, 2024

Deployment Type

Self-hosted

NetBox Version

v4.0-beta2

Python Version

3.11

Steps to Reproduce

1- Create a 42 RU rack
2- Create two devices-types with interfaces, then two devices of this type and assign them to this rack.
3- Connect the interfaces together using a cable
4- Navigate the Rack elevation or perform a cable trace

(step 4 can also be simply executed on https://beta-demo.netbox.dev/ with existing demo data)

Expected Behavior

SVG objects should have their color-scheme set to auto, which should display a transparent background, and white text for labels in dark mode.

image
image

Observed Behavior

SVG objects are displaying a white background (and black text) with bad looking padding which is not aligned with the rest of the UI. This is observed on a chrome based browser. Safari seems to have a transparent background which lack contrast with the text.

image
image

@jsenecal jsenecal added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 25, 2024
@jsenecal jsenecal changed the title Some SVG UI elements have white backgrounds in dark mode SVG UI elements background issues in dark mode Apr 25, 2024
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Apr 26, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 26, 2024
@arthanson arthanson removed their assignment Apr 26, 2024
@arthanson
Copy link
Collaborator

This is a superset of #15819 leaving this one open as it shows there are more effects then just the rack-elevation.

@arthanson arthanson self-assigned this Apr 26, 2024
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 26, 2024
@arthanson
Copy link
Collaborator

The rack one I think is HTMX enabled issue only, it works fine on mine if that is not enabled. I do see the cable trace one being the wrong background even if HTMX is not enabled. Strangely safari displays it fine but chrome does not.

@jeffgdotorg jeffgdotorg added the topic: UI/UX User interface or user experience related work label Apr 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

4 participants