Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit clickable width of filter form row #15678

Closed
julianstolp opened this issue Apr 10, 2024 · 3 comments
Closed

Limit clickable width of filter form row #15678

julianstolp opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available type: bug A confirmed report of unexpected behavior in the application

Comments

@julianstolp
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Go to any model
  2. Open the Filters tab
  3. Every field is clickable to the most left side of the card

Similar issue #15620

Expected Behavior

The filters should be styled like any other edit form in NetBox for consistency reasons.
At least dropdown fields should not be clickable the full row like in 3.7.x realeases.

Observed Behavior

  1. Clickable on full row width which is rather annoying if dropdown gets opened if you did not even click near the field or label.
    image
@julianstolp julianstolp added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Apr 10, 2024
@aryansanchiya
Copy link

I think not every field is clickable from the left side of the card, there is only one field is clickable from the left side of the card and its "search" field.

@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 29, 2024
@arthanson arthanson assigned arthanson and unassigned abhi1693 Apr 29, 2024
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 30, 2024
@arthanson
Copy link
Collaborator

Actually this is the way bootstrap works, if you go to other forms the form width is narrower so the clickable area on the left is narrower, if you click on the far-left side it doesn't select, but if you click further to the right it will select just like on the filters form (see red block in screenshot). You can actually see the same behavior with the bootstrap examples (but to the right of the label as they are left aligned) at https://getbootstrap.com/docs/5.3/forms/layout/#horizontal-form-label-sizing

Closing as by design.
Monosnap Add a new device | NetBox 2024-04-30 15-38-10

@julianstolp
Copy link
Author

@arthanson I agree with you the device creation form is fine. In this issue I was talking about the filter forms. The picture displays the clickable width.
grafik

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Concerns a bug/feature in a beta release severity: low Does not significantly disrupt application functionality, or a workaround is available type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

4 participants