Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to Circuit Types model and use this when rendering cable traces #12216

Closed
decoupca opened this issue Apr 10, 2023 · 6 comments · Fixed by #14098
Closed

Add colors to Circuit Types model and use this when rendering cable traces #12216

decoupca opened this issue Apr 10, 2023 · 6 comments · Fixed by #14098
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@decoupca
Copy link
Contributor

NetBox version

v3.4.6

Feature type

New functionality

Proposed functionality

As described in this discussion, make it possible to identify the type of circuit that's involved in a cable trace by color-coding circuit types, and including the circuit type's name in the circuit's block in the diagram.

This would involve:

  • Extending the circuit type model to include a color value (identical to how device roles are color-coded);
  • Updating the cable trace view to reflect the circuit type's color and name.

This FR proposes no changes to cable traces that do not involve a circuit.

Use case

Currently there is no way to identify the type of a circuit involved in a cable trace just by looking at the diagram. Color-coding and labeling circuit types adds convenience when looking at multiple cable traces, especially if the cable trace is exported or viewed by someone without access to NetBox, and hence can't resolve the circuit type by clicking on it, or looking it up.

Database changes

Circuit types need a field for color value.

External dependencies

None.

@decoupca decoupca added the type: feature Introduction of new functionality to the application label Apr 10, 2023
@decoupca
Copy link
Contributor Author

decoupca commented Apr 10, 2023

Had some time to play with this, if approved I'd like to handle it.

image

image

image

@decoupca decoupca changed the title Make it possible to identify circuit type in cable traces Add colors to Circuit Types model and use this when rendering cable traces Apr 10, 2023
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label May 4, 2023
@decoupca
Copy link
Contributor Author

@jeremystretch Is there anything I can contribute to assist the review? This feature has come up a few times on my team. Thanks!

@jasonbothe-moodys
Copy link

@jeremystretch I would really really like to like some traction on this. Would it be possible to elevate it? Many thanks to @decoupca for the willingness to contribute in making this feature a reality.

@DanSheps
Copy link
Member

Make sure you "thumbs up" the main issue, that is how we triage featurues

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Oct 13, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Oct 13, 2023
@jeremystretch
Copy link
Member

@decoupca I assigned this to @arthanson before I noticed your comment above. Would you like to own this one?

@jasonbothe
Copy link

Thank you gents!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants