Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist page size preference across views #11807

Closed
jeremystretch opened this issue Feb 22, 2023 · 3 comments
Closed

Don't persist page size preference across views #11807

jeremystretch opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.4.5

Feature type

Change to existing functionality

Proposed functionality

When viewing a list of objects in the NetBox UI, the user can select a page size to determine how many objects to render in one view. (Default options range between 25 and 1000 objects.) Once a page size has been selected, it will persist as the user navigates to other areas of the application. This FR proposes removing the persistence, so that navigating to a different object view returns the default page size.

Use case

We've found that users will often increase the page size while viewing one type of object for a specific purpose, without realizing as they navigate elsewhere in NetBox that the page size has remained in effect. This can lead to frustration stemming from unnecessarily long load times as many more objects than required are being fetched.

Database changes

No response

External dependencies

No response

@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Feb 22, 2023
@jsenecal
Copy link
Contributor

Would persistence follow the page size preference of the individual user ?

@jeremystretch
Copy link
Member Author

jeremystretch commented Feb 23, 2023

@jsenecal are you referring to the "page length" user preference?

Screenshot 2023-02-23 at 16-13-36 User Preferences NetBox

I think we'd still allow a user to set their global preference this way; we just wouldn't update it automatically when specifying a page size under a specific table.

@jsenecal
Copy link
Contributor

Yes, this is what I had in mind. The behavior you described works for me. I would change the description to The default number of objects to display per page however.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Feb 27, 2023
@jeremystretch jeremystretch self-assigned this Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants