Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An superuser is unconditionally created on startup #160

Closed
kkthxbye-code opened this issue Oct 11, 2019 · 3 comments · Fixed by #163
Closed

An superuser is unconditionally created on startup #160

kkthxbye-code opened this issue Oct 11, 2019 · 3 comments · Fixed by #163
Labels
awaiting answer There is still some open discussion. bug This issue describes a confirmed bug. pr There is a PR targeting this issue.

Comments

@kkthxbye-code
Copy link

It is not possible to skip the creation of a superuser. The logic can be seen here.

The documentation says the following:
SUPERUSER_*: Only define those variables during the initial setup, and drop them once the DB is set up. Don't use the default passwords!

This is potentially dangerous, because if you did change SUPERUSER_NAME to something other than admin, and after the first run removed all the SUPERUSER_ options, a new superuser named admin would be created.

I think the best solution is to just skip the creation of the superuser if the required SUPERUSER_ variables are not set. When using LDAP auth, it doesn't really make sense to have a statically defined superuser.

@cimnine cimnine added bug This issue describes a confirmed bug. help wanted We seek out help for implementing this issue. labels Oct 11, 2019
@cimnine
Copy link
Collaborator

cimnine commented Oct 12, 2019

Would #163 be a viable 'solution' to you?

The PR would introduce a new env variable SKIP_SUPERUSER, which – when set to true – would prevent creating the superuser.

@cimnine cimnine added awaiting answer There is still some open discussion. pr There is a PR targeting this issue. and removed help wanted We seek out help for implementing this issue. labels Oct 12, 2019
@kkthxbye-code
Copy link
Author

Looks good to me, that would fix our issue. Thanks for the quick fix.

@cimnine
Copy link
Collaborator

cimnine commented Oct 13, 2019

There is a new release containing the PR #163. Only new images for snapshot and latest are automatically re-built and pushed to Docker Hub. Versioned releases, e.g. v2.6.6, are not rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting answer There is still some open discussion. bug This issue describes a confirmed bug. pr There is a PR targeting this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants