landlock: split .special into .makeipc and .makedev #6187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to see this design choice getting corrected.
|
As discussed with @topimiettinen[1], it is unlikely that an unprivileged process would need to directly create block or character devices. Also, `landlock.special` is not very descriptive of what it allows. So split `landlock.special` into: * `landlock.makeipc`: allow creating named pipes and sockets (which are usually used for inter-process communication) * `landlock.makedev`: allow creating block and character devices Misc: The `makedev` name is based on `nodev` from mount(8), which makes mount not interpret block and character devices. `ipc` was suggested by @rusty-snake[2]. Relates to netblue30#6078. [1] netblue30#6078 (review) [2] netblue30#6187 (comment)
kmk3
force-pushed
the
landlock-add-dev
branch
from
0485cbe to
f70ffbe
Compare
kmk3
changed the title
Good idea, renamed them to |
topimiettinen
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @topimiettinen[1], it is unlikely that an unprivileged
process would need to directly create block or character devices. Also,
landlock.specialis not very descriptive of what it allows.So split
landlock.specialinto:landlock.makeipc: allow creating named pipes and sockets (which areusually used for inter-process communication)
landlock.makedev: allow creating block and character devicesMisc: The
makedevname is based onnodevfrom mount(8), which makesmount not interpret block and character devices.
ipcwas suggested by@rusty-snake[2].
Relates to #6078.
[1] #6078 (review)
[2] #6187 (comment)