Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: cannot open file chooser with "Save Page As..." #6563

Open
4 of 7 tasks
Druco opened this issue Dec 2, 2024 · 4 comments
Open
4 of 7 tasks

firefox: cannot open file chooser with "Save Page As..." #6563

Druco opened this issue Dec 2, 2024 · 4 comments
Labels
needinfo More information is needed from the issue author sandbox-ipc Opening links and talking to programs outside of the sandbox (see #6462)

Comments

@Druco
Copy link

Druco commented Dec 2, 2024

Description

Just updated to Firefox 133.0 and 'Save Page As...' no longer works.

Steps to Reproduce

  1. Start Firefox 133.0 with 'firejail firefox'
  2. Open a web page
  3. Select File->Save Page As...

Expected behavior

A File Chooser dialog should open

Actual behavior

No File Chooser dialog opens

Behavior without a profile

Firefox works as expected

Additional context

Prior to Firefox v133.0 this was not a problem so it is definitely something that has changed.

I was able to fix the problem by adding:
dbus-user.talk org.freedesktop.portal.*
to my firefox.local file but this may not be the optimal fix.

I tried:
dbus-user.talk org.freedesktop.portal.FileChooser.*
which appeared to me to be the actual interface being used but this did not work.

Environment

  • Linux 6.11.8-1-default x86_64
  • OpenSuSE Tumbleweed 20211129
  • firejail v 0.9.72

Checklist

  • The issues is caused by firejail (i.e. running the program by path (e.g. /usr/bin/vlc) "fixes" it).
  • I can reproduce the issue without custom modifications (e.g. globals.local).
  • The program has a profile. (If not, request one in https://github.com/netblue30/firejail/issues/1139)
  • The profile (and redirect profile if exists) hasn't already been fixed upstream.
  • I have performed a short search for similar issues (to avoid opening a duplicate).
    • I'm aware of browser-allow-drm yes/browser-disable-u2f no in firejail.config to allow DRM/U2F in browsers.
  • I used --profile=PROFILENAME to set the right profile. (Only relevant for AppImages)

Log

@kmk3 kmk3 changed the title Firefox v 133.0 won't open file chooser when 'Save Page As...' selected firefox: cannot open file chooser with "Save Page As..." Dec 2, 2024
@rusty-snake
Copy link
Collaborator

rusty-snake commented Dec 2, 2024

dbus-user.talk org.freedesktop.portal.FileChooser.*

The name should be org.freedesktop.portal.Documents which is already allowed in firefox-common.profile to fix drag and drop under some(?) systems. So this issue can likely be closed as an duplicate.

@kmk3 kmk3 added the sandbox-ipc Opening links and talking to programs outside of the sandbox (see #6462) label Dec 2, 2024
@Druco
Copy link
Author

Druco commented Dec 2, 2024

Thanks for the quick reply.

I found that adding just "org.freedesktop.portal.Documents" did not work. After some more debug, I found that it also required "org.freedesktop.portal.Desktop" to be included, which is commented in firefox-common.profile to indicate that it is needed for "sceensharing under Wayland", so perhaps the comment could be changed to say that it may also be needed for file saving to work under FF133.

@kmk3
Copy link
Collaborator

kmk3 commented Dec 3, 2024

Just updated to Firefox 133.0 and 'Save Page As...' no longer works.

I found that adding just "org.freedesktop.portal.Documents" did not work.
After some more debug, I found that it also required
"org.freedesktop.portal.Desktop" to be included

Does it work with firejail-git?

Also can you try the following and post the result?

@kmk3 kmk3 added the needinfo More information is needed from the issue author label Dec 3, 2024
@Druco
Copy link
Author

Druco commented Dec 4, 2024

I pulled master from github and that version does not work out of the box. I have attached four files, two with the output from the comment you listed and two from when I ran with the command '/usr/local/bin/firejail --dbus-user=filter --dbus-user.log --dbus-log=xxx.dbus firefox'.

The two that have 'noDesktop' in the name are run from the git firejail as is, and the file chooser popup never came up. The two that have 'withDesktop' in the name were run with the line "dbus-user.talk org.freedesktop.portal.Desktop" added to my 'firefox.local' file and worked as expected
NoDesktop.dbus.txt
WithDesktop.dbus.txt
busctl_noDesktop.txt
busctl_withDesktop.txt
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo More information is needed from the issue author sandbox-ipc Opening links and talking to programs outside of the sandbox (see #6462)
Projects
None yet
Development

No branches or pull requests

3 participants