Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache.interceptor.ts #11252

Closed
wants to merge 1 commit into from
Closed

Conversation

drahmedjava
Copy link

@drahmedjava drahmedjava commented Mar 9, 2023

the arguments expected by cacheManager on case of ttl are: (key, value, ttl: number)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

the arguments expected by cacheManager on case of ttl are: (key, value, ttl: number)
@coveralls
Copy link

Pull Request Test Coverage Report for Build e6b7897d-18c3-48a0-be75-a3a350a473c3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.885%

Totals Coverage Status
Change from base Build e491e778-9791-4abc-961c-45d230529fe8: 0.0%
Covered Lines: 6488
Relevant Lines: 6985

💛 - Coveralls

@drahmedjava
Copy link
Author

I am new user of nest, and by just following the instructions here using the default in-memory store https://docs.nestjs.com/techniques/caching found that @CacheTTL not working as expected. but calling cacheManager.set(key, value, ttl) directly worked fine

@kamilmysliwiec
Copy link
Member

#11131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants