-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service discovery - announce _teleplot._udp via mDNS-SD #18
Comments
I do like the idea but have questions on how it will work. Advertising a DNS name on the network might confuse two person using teleplot (for their own purpose) while being connected on the same network (like in an office). What we don't want is the telemetry from personA plotted on personB's PC. This concern is true for both privacy, performances and usability reasons. (ye I do plan to update the VSCode plugin to match recent updates but I didn't dedicated the necessary time yet) |
I do have a working implementation server- and client (Arduino) side, need to clean up before publishing, should be a few days the way I did it is:
client can also explicitly browse for announcements, and displays what she discovers to address your concern, one could disable the 'pick first announcement if not configured explicitly' behavior this makes the simple case easy and the complicated possible Michael |
this branch has the mDNS announcement client examples forthcoming (sorry for the whitespace reformat) |
here's an ESP32 Arduino example which does mDNS discovery: https://github.com/mhaberler/esp32-imu-baro/blob/master/src/teleplot/arduino.cpp I did rewrite Teleplot.h into https://github.com/mhaberler/esp32-imu-baro/blob/master/src/teleplot/Teleplot.h massively for embedded use
the changes were so extensive I dropped the idea of retaining your API - sorry for that there's a native (in my case MacOS) example here, without service discovery: https://github.com/mhaberler/esp32-imu-baro/blob/master/src/teleplot/native.cpp what do you think? |
planning to add mDNS-SD service announcements so teleplot clients can find a local teleplot server automatically
following this example: https://github.com/mdns-js/node-mdns-js/blob/master/examples/service.js
are you willing to entertain PR's for that?
thanks for the great tool, btw! really appreciated
Michael
ps: any plans to bring up the VSCode teleplot plugin on par with this server in terms of features? seems 3D mode is missing
The text was updated successfully, but these errors were encountered: