From 4275a3de3a5ba623de33dfc48052f75a532b1590 Mon Sep 17 00:00:00 2001 From: Keith Date: Wed, 21 Dec 2022 20:19:29 +0800 Subject: [PATCH] ci: specify macos version MacOS is specified by version number explicitly because tag "macos-latest" refers to macos-11 or macos-12 randomly during GitHub action's transition while macos 12 removed Python 2 which is required by electron-builder. Since latest electron-builder has supported python3, this hotfix will not introduce python2 in host but downgrade it to macos 12 Ref: https://github.com/electron-userland/electron-builder/issues/6606 --- .github/workflows/package.yml | 8 ++++---- .github/workflows/package_for_test.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml index 6193acc170..d8ac449b12 100644 --- a/.github/workflows/package.yml +++ b/.github/workflows/package.yml @@ -14,7 +14,7 @@ jobs: node: - 16.10.0 os: - - macos-latest + - macos-11 - ubuntu-20.04 - windows-2019 @@ -67,7 +67,7 @@ jobs: CI: false - name: Package for MacOS - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' run: | ./scripts/download-ckb.sh mac yarn release mac @@ -99,14 +99,14 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Upload Neuron App Zip - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' uses: actions/upload-artifact@v2 with: name: Neuron-Mac path: release/Neuron-*-mac.zip - name: Upload Neuron Dmg - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' uses: actions/upload-artifact@v2 with: name: Neuron-Dmg diff --git a/.github/workflows/package_for_test.yml b/.github/workflows/package_for_test.yml index 737dabefcc..e931b3fe85 100644 --- a/.github/workflows/package_for_test.yml +++ b/.github/workflows/package_for_test.yml @@ -9,7 +9,7 @@ jobs: node: - 16.10.0 os: - - macos-latest + - macos-11 - ubuntu-20.04 - windows-2019 @@ -62,7 +62,7 @@ jobs: CI: false - name: Package for MacOS - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' run: | ./scripts/download-ckb.sh mac yarn package:test mac @@ -94,14 +94,14 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Upload Neuron App Zip - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' uses: actions/upload-artifact@v2 with: name: Neuron-Mac path: release/Neuron-*-mac.zip - name: Upload Neuron Dmg - if: matrix.os == 'macos-latest' + if: matrix.os == 'macos-11' uses: actions/upload-artifact@v2 with: name: Neuron-Dmg