Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

fix(network): negative connecting metric number #430

Merged

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Aug 24, 2020

What this PR does / why we need it:
Use collection's length directly, this should fix negative connecting number gauge now.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

@yejiayu
Copy link
Contributor

yejiayu commented Aug 24, 2020

/lgtm

@muta-robot muta-robot added the lgtm #8ef42e label Aug 24, 2020
@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yejiayu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muta-robot muta-robot merged commit dae62ae into nervosnetwork:master Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants