Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

feat(benchmark): add a perf benchmark macro #391

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

KaoImin
Copy link

@KaoImin KaoImin commented Aug 3, 2020

What type of PR is this?
feat

What this PR does / why we need it:
Add a perf benchmark macro to do benchmark when assets exist.

10 assets bench::perf_execute  ... bench: 109,202,563 ns/iter (+/- 6,378,009)
100 assets bench::perf_execute  ... bench: 108,859,512 ns/iter (+/- 2,977,622)
1000 assets bench::perf_execute ... bench: 108,037,404 ns/iter (+/- 4,539,634)
10000 asset bench::perf_execute  ... bench: 100,244,123 ns/iter (+/- 18,935,087)

It seems that performance has nothing to do with the number of existing assets.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@yejiayu
Copy link
Contributor

yejiayu commented Aug 4, 2020

/lgtm

@muta-robot muta-robot added the lgtm #8ef42e label Aug 4, 2020
@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yejiayu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muta-robot muta-robot merged commit eb24311 into nervosnetwork:master Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants