Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove reduandent checking deposits expired #703

Merged
merged 2 commits into from
May 26, 2022
Merged

perf: remove reduandent checking deposits expired #703

merged 2 commits into from
May 26, 2022

Conversation

keroro520
Copy link
Contributor

No description provided.

@keroro520 keroro520 requested review from jjyr, blckngm and zeroqn May 25, 2022 04:00
@gw-bot
Copy link

gw-bot bot commented May 25, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2382049381

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@gw-bot
Copy link

gw-bot bot commented May 25, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2382155745

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

Run Result

failure

keroro520
keroro520 commented May 25, 2022
View reviewed changes
crates/mem-pool/src/pool.rs
if force_expired {
log::debug!("[mem-pool] forced clear pending deposits");
self.pending_deposits.clear();
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers, when force_expired is true, we should clear self.pending_deposits before making the safe_expired prediction. Otherwise safe_expired will always be false when force_expired is equal to true.

@jjyr jjyr merged commit f86d655 into develop May 26, 2022
@jjyr jjyr deleted the optimize-determining-whether-deposits-expired branch May 26, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyr jjyr jjyr approved these changes

@blckngm blckngm blckngm approved these changes

@zeroqn zeroqn zeroqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keroro520 @jjyr @blckngm @zeroqn