New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[open_channel] open a private channel when pubic is none #326

Closed

gpBlockchain opened this issue Nov 20, 2024 · 2 comments · Fixed by #331

Contributor

gpBlockchain commented Nov 20, 2024

fiber/src/rpc/channel.rs

Line 405 in 78a4da8

public: params.public.unwrap_or(false),

Collaborator

chenyukang commented Nov 21, 2024

@quake @contrun
it's better to set default channel to be public?

Member

quake commented Nov 21, 2024

I think so, I will create a PR for this issue.

quake mentioned this issue

fix: channel should be public by default #331

Merged

chenyukang closed this as completed in #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment