Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC doc for trace_transaction and get_transaction_trace is misleading #217

Closed
ashchan opened this issue Jan 21, 2019 · 2 comments
Closed

RPC doc for trace_transaction and get_transaction_trace is misleading #217

ashchan opened this issue Jan 21, 2019 · 2 comments
Assignees
@quake @zhangsoledad

Comments

@ashchan
Copy link
Contributor

ashchan commented Jan 21, 2019

Describe the bug
RPC doc for trace_transaction and get_transaction_trace is misleading.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/nervosnetwork/ckb/blob/e759128af3b041406a6204369ea273b266ce12a7/rpc/doc.md#trace_transaction
  2. Check the method description
  3. Both methods describe themselves as Creates new transaction.

Expected behavior
Proper description of these two RPC methods.
@doitian
Copy link
Member

doitian commented Jan 21, 2019

The RPC get_transaction_trace gets the status of the transaction submited by trace_transaction.

@zhangsoledad
Copy link
Member

#218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quake quake

@zhangsoledad zhangsoledad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ashchan @quake @doitian @zhangsoledad