Remove unnecessary catch-all error handling

nervosnetwork · Sep 24, 2024 · 4e2db00 · 4e2db00
1 parent 8e2e80f
commit 4e2db00
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 10 deletions.
diff --git a/contracts/ckb-std-tests/src/error.rs b/contracts/ckb-std-tests/src/error.rs
@@ -29,7 +29,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/exec-callee/src/error.rs b/contracts/exec-callee/src/error.rs
@@ -29,7 +29,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/exec-caller-by-code-hash/src/error.rs b/contracts/exec-caller-by-code-hash/src/error.rs
@@ -29,7 +29,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/exec-caller/src/error.rs b/contracts/exec-caller/src/error.rs
@@ -29,7 +29,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/spawn-callee/src/error.rs b/contracts/spawn-callee/src/error.rs
@@ -28,7 +28,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/spawn-caller-by-code-hash/src/error.rs b/contracts/spawn-caller-by-code-hash/src/error.rs
@@ -28,7 +28,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/contracts/spawn-caller/src/error.rs b/contracts/spawn-caller/src/error.rs
@@ -28,7 +28,6 @@ impl From<SysError> for Error {
             MaxVmsSpawned => Self::MaxVmsSpawned,
             MaxFdsCreated => Self::MaxFdsCreated,
             Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-            _ => panic!("other sys error"),
         }
     }
 }
diff --git a/src/error.rs b/src/error.rs
@@ -21,6 +21,7 @@ pub enum SysError {
     /// Max fds has been spawned. Its value is 9.
     MaxFdsCreated,
     /// Type ID Error
+    #[cfg(feature = "type-id")]
     TypeIDError,
     /// Unknown syscall error number
     Unknown(u64),

diff --git a/test/simulator/src/exec_callee.rs b/test/simulator/src/exec_callee.rs
@@ -34,7 +34,6 @@ pub mod error {
                 MaxVmsSpawned => Self::MaxVmsSpawned,
                 MaxFdsCreated => Self::MaxFdsCreated,
                 Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-                _ => panic!("other sys error"),
             }
         }
     }

diff --git a/test/simulator/src/exec_caller_by_code_hash.rs b/test/simulator/src/exec_caller_by_code_hash.rs
@@ -34,7 +34,6 @@ pub mod error {
                 MaxVmsSpawned => Self::MaxVmsSpawned,
                 MaxFdsCreated => Self::MaxFdsCreated,
                 Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-                _ => panic!("other sys error"),
             }
         }
     }

diff --git a/test/simulator/src/main.rs b/test/simulator/src/main.rs
@@ -37,7 +37,6 @@ pub mod error {
                 MaxVmsSpawned => Self::MaxVmsSpawned,
                 MaxFdsCreated => Self::MaxFdsCreated,
                 Unknown(err_code) => panic!("unexpected sys error {}", err_code),
-                _ => panic!("other sys error"),
             }
         }
     }