Skip to content

Commit

Permalink
feat(types): remove the args field in cell input type
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the type of cell input changes, its args field is removed.
  • Loading branch information
Keith-CY committed Jun 4, 2019
1 parent e91ace5 commit d07f253
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 29 deletions.
26 changes: 0 additions & 26 deletions packages/ckb-sdk-rpc/__tests__/formatters/fixtures.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"blockHash": "0x0000000000000000000000000000000000000000000000000000000000000000"
}],
"inputs": [{
"args": ["0x0200000000000000"],
"previousOutput": {
"cell": {
"txHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -98,7 +97,6 @@
"block_hash": "0x0000000000000000000000000000000000000000000000000000000000000000"
}],
"inputs": [{
"args": ["0x0200000000000000"],
"previous_output": {
"cell": {
"tx_hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -142,9 +140,6 @@
}],
"toInput": [{
"source": {
"args": [
"0x0200000000000000"
],
"previous_output": {
"cell": {
"hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand All @@ -155,9 +150,6 @@
"since": "0"
},
"target": {
"args": [
"0x0200000000000000"
],
"previousOutput": {
"cell": {
"hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -262,9 +254,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previous_output": {
"cell": {
"tx_hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand All @@ -291,9 +280,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previousOutput": {
"cell": {
"txHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -387,9 +373,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previous_output": {
"cell": {
"tx_hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -437,9 +420,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previousOutput": {
"cell": {
"txHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -770,9 +750,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previous_output": {
"cell": {
"tx_hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down Expand Up @@ -804,9 +781,6 @@
"deps": [],
"hash": "0x8027376875e45318ed469bed6314408e8f1986de246cbd03a786b69073c948b8",
"inputs": [{
"args": [
"0x0200000000000000"
],
"previousOutput": {
"cell": {
"txHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
Expand Down
1 change: 0 additions & 1 deletion packages/ckb-sdk-rpc/types/CKB_RPC/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ declare module CKB_RPC {
export interface CellInput {
previous_output: OutPoint
since: Since
args: Bytes[]
}

export interface CellOutput {
Expand Down
2 changes: 0 additions & 2 deletions packages/ckb-types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,10 @@ declare namespace CKBComponents {
* @property previousOutput, point to its P1 cell
* @property since, a parameter to prevent a cell to be spent before a centain block timestamp or a block number,
* [RFC](https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0017-tx-valid-since/0017-tx-valid-since.md)
* @property args, args to unlock cell
*/
export interface CellInput {
previousOutput: OutPoint
since: Since
args: Bytes[]
}

/**
Expand Down

0 comments on commit d07f253

Please sign in to comment.