Gzip request body if server support it #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 112 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
BartoszPrusak
previously approved these changes
Sep 28, 2023
AleksanderWWW
previously approved these changes
Oct 3, 2023
Raalsky
reviewed
Oct 4, 2023
| def send(self, request, stream=False, **kw): | ||
| if request.body is not None and not stream: | ||
| request_body = request.body if isinstance(request.body, bytes) else bytes(request.body, "utf-8") | ||
| gzip_compress = zlib.compressobj(zlib.Z_DEFAULT_COMPRESSION, zlib.DEFLATED, zlib.MAX_WBITS | 16) |
There was a problem hiding this comment.
Can we try catch that wrt. to https://docs.python.org/3/library/zlib.html#zlib.error?
There was a problem hiding this comment.
I don't think it's necessary because an exception is very generic.
There was a problem hiding this comment.
They mentioned that this could happen on compression as well
Raalsky
reviewed
Oct 4, 2023
PatrykGala
force-pushed
the
pg_gzip-upload
branch
from
05c38a8 to
5a81fd1
Compare
Raalsky
approved these changes
Oct 9, 2023
aniezurawski
added a commit
that referenced
this pull request
Oct 9, 2023
This reverts commit 462afe5.
Raalsky
pushed a commit
that referenced
this pull request
Oct 9, 2023
Co-authored-by: BartoszPrusak <[email protected]>
PatrykGala
added a commit
that referenced
this pull request
Oct 10, 2023
This reverts commit 799e9d8.
PatrykGala
added a commit
that referenced
this pull request
Oct 10, 2023
This reverts commit 6eeaf34.
Raalsky
pushed a commit
that referenced
this pull request
Oct 10, 2023
Co-authored-by: BartoszPrusak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist