Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics #451

Closed
jochem4207 opened this issue Jul 20, 2023 · 7 comments · Fixed by #452
Closed

Google Analytics #451

jochem4207 opened this issue Jul 20, 2023 · 7 comments · Fixed by #452
Assignees
Labels
Question Further information is requested

Comments

@jochem4207
Copy link

Hey Guys,

I'm absolutely loving this project. Just started working with HangFire and seems to work well!
I noticed while going trough some files that your google analytics ID is in here. Maybe that should be changed to an empty value or something.

It's in ConfigureServices.cs in Blazor.Server.UI project

@Bram1903
Copy link
Collaborator

Hey,

I'm not sure whether @neozhu tries to observe how many people are using the codebase, or that it should be configurable.
@neozhu, what's the idea behind having the Google analytics id hardcoded? If you want I can make it configurable?

Kind regards,
Bram

@Bram1903 Bram1903 added the Question Further information is requested label Jul 20, 2023
@neozhu
Copy link
Owner

neozhu commented Jul 21, 2023

To be honest, I am not sure about the specific uses of Google Analytics. I simply copied the configuration from Microsoft's official settings. If it is not necessary, I think we can remove it.
@Bram1903 Bram, I would greatly appreciate it if you could help make it configurable so that users can decide whether to enable Google Analytics themselves."

@Bram1903
Copy link
Collaborator

@neozhu, see #452.

@jochem4207
Copy link
Author

Holy shit that was quick :)

@Bram1903
Copy link
Collaborator

Holy shit that was quick :)

Haha, indeed, it was quite swift! After waking up and seeing Neozhu's request to make it configurable, I promptly worked on the entire update, finishing it in approximately 15 minutes. Thank you for bringing up this issue. Is there anything else you would like to discuss or need help with?

@Bram1903 Bram1903 linked a pull request Jul 21, 2023 that will close this issue
@neozhu
Copy link
Owner

neozhu commented Jul 21, 2023

@Bram1903 Thanks for your effort and support

@neozhu neozhu closed this as completed Jul 21, 2023
@jochem4207
Copy link
Author

jochem4207 commented Jul 21, 2023

@Bram1903 damn, super speed.

At the moment just working on building the CRUD interface and on recurring HangFire Jobs. I'm curious if and how they can be created following the Clean Architecture. I want them to run monthly/daily etc.

Now I created a UI page -> triggers a command -> creates the job (copied the from Logging and DocumentOcr)

But thats totally unrelated :)

Edit: I'm also wondering how I should keep my local project up to date with the git repo. But that's something for later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants