Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint stops functioning after updating vscode-langservers-extracted to 4.10.0 #3146

Closed
mguellsegarra opened this issue May 11, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@mguellsegarra
Copy link

Description

Hello,

I've encountered an issue with ESLint after updating the vscode-langservers-extracted package from version 4.8.0 to versions 4.9.0 and 4.10.0. Upon updating, ESLint functionality appears to break. Tested in different OS's and different node versions.

Before the update (at version 4.8.0), ESLint was functioning as expected within my projects, providing linting feedback and error/warning highlights in my code.

After updating to 4.9.0 and then 4.10.0, ESLint no longer provides linting feedback.

I'm unsure if this is the correct place to report this issue, but I wanted to bring it to your attention in case others are experiencing similar problems. Thank you for your help and for maintaining this important tool.

@justinmk
Copy link
Member

Thanks for your report. The configs in this repo are unsupported and provided only as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and send improvements.

If you have a usage question, try asking it at:

If you found a bug in the core Nvim vim.lsp module (not part of this repo), the best way to get it fixed is to report to Nvim (not nvim-lspconfig) with:

  • steps to reproduce it without the particular LSP server and other factors particular to your environment
  • (optional, but very helpful): by adding a failing test case to lsp_spec.lua, which has code to setup a fake LSP server to simulate various scenarios

@justinmk justinmk closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2024
@mguellsegarra
Copy link
Author

@justinmk hey, I appreciate your time and apologize for mistakenly posting this issue in the incorrect repo. Will try to fix it and report it properly. Thanks!

@jackpinto
Copy link

@mguellsegarra

Do you have any clues on how to fix the setup for version 4.10?

I am looking, but I haven't found anything so far.

mguellsegarra referenced this issue in hrsh7th/vscode-langservers-extracted May 12, 2024
@9mm
Copy link

9mm commented May 13, 2024

Im also encountering this, and vscode-langservers-extracted has no issues enabled to even report the issue. I cant really imagine stack overflow is the best place to put bug reports. maybe @hrsh7th can be summoned?

@jackpinto @mguellsegarra what behavior are you experiencing? For me, the diagnostics just dont show at all, however if i run EslintFixAll it DOES work, so i know lspconfig/eslint is reading the proper project eslintrc file etc, it just simply will not show any diagnostics. theres also no errors in LspLog, and all of that is working properly it seems

@heygarrett
Copy link

heygarrett commented May 15, 2024

Workaround:

  1. Uninstall eslint-lsp with Mason
  2. npm install --global [email protected]
  3. Add require("lspconfig").eslint.setup({}) to your config

@when-harry-met-sally
Copy link

MasonInstall [email protected] worked for me.

@jackpinto
Copy link

@9mm same here, it only doesn't show the diagnostics.

@mguellsegarra
Copy link
Author

@jackpinto @mguellsegarra what behavior are you experiencing?

Diagnostics don't show up, sadly. I ended up putting all my share/nvim/ folder into a git repo for controlling all the Mason updates, because there's no way to lock versions. Sticking to 4.8.0 for the moment, until I have time to investigate what happened.

@mguellsegarra
Copy link
Author

Just wanted to update everyone—I've opened a PR addressing the issue we've been discussing. You can follow the conversation here.

@adibfirman
Copy link

adibfirman commented Jun 13, 2024

Installing like @when-harry-met-sally suggested it, works for me
oh config how do I make sure Mason will install with the specific version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants