Investigate if we need to re-forward properties

[nomego]

When implementing "realign" for scenarios where items disappear from the item list, but other items that are rendered should stay intact (

cosmoz-data-nav/cosmoz-data-nav.js

Line 598 in 82f234f

_realignElements(index) { // eslint-disable-line max-statements

), we also re-forward the properties (

cosmoz-data-nav/cosmoz-data-nav.js

Line 619 in 82f234f

Object.keys(props).forEach(key => instance._setPendingProperty(key, props[key]));

+ 620).

This causes us to actually re-stamp/re-eval the same instance, which in turn, in some cases, causes the views to re-request information from BE unnecessarily.

Can we safely drop this property forwarding for existing, rendered elements or why is it there in the first place?

This can be tested in Cosmoz FE view "Purchase -> Orders -> Orders rows with quantity differences" -> Queue -> action "Approve order row".
You will notice that history and suggestions are called twice, even though we only request information for one new row.

[cristinecula]

@nomego I tried disabling the prop forwarding, by removing those lines in _realignElements, but (aside from causing errors in the tests) the multiple requests for the same id appear to continue to be happening.
The data-nav logic is very complex and hard to follow, so more investigation is needed.
In the long run, I think separating the data layer from the view layer would result in more benefits, than patching this library. The view layer should not make API requests directly, but instead only display the data. If we do this correctly, then we can forward props all the time, without triggering network requests.

[github-actions]

🎉 This issue has been resolved in version 3.0.6 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀