feat(👻): extract cache behavior with haunted-polymer hook #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomego
force-pushed
the
haunted-polymer-cache
branch
from
8c1541f to
50ccfb0
Compare
nomego
changed the title
nomego
changed the title
added 2 commits
June 18, 2020 09:20
Start with a small hook to extract as much of the caching as possible. Also fixes a test suite setup. WIP to move to haunted-polymer from cosmoz-utils if merged. Signed-off-by: Patrik Kullman <[email protected]>
Signed-off-by: Patrik Kullman <[email protected]>
nomego
force-pushed
the
haunted-polymer-cache
branch
from
50ccfb0 to
28cd82c
Compare
nomego
changed the title
nomego
changed the title
cristinecula
requested changes
Jun 18, 2020
cosmoz-data-nav.js
Outdated
| @@ -23,6 +23,10 @@ import '@neovici/cosmoz-bottom-bar/cosmoz-bottom-bar-view'; | |||
| import { translatable } from '@neovici/cosmoz-i18next'; | |||
| import '@neovici/cosmoz-page-router/cosmoz-page-location'; | |||
|
|
|||
| import { hauntedPolymer } from '@neovici/cosmoz-utils'; | |||
|
|
|||
| import { useCache } from './lib/cache.js'; | |||
There was a problem hiding this comment.
I think it's a good convention to include use- in the filename: use-cache.js
Signed-off-by: Patrik Kullman <[email protected]>
cristinecula
approved these changes
Jun 18, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2020
# [3.4.0](v3.3.3...v3.4.0) (2020-06-18) ### Features * **👻:** extract cache behavior with haunted-polymer hook ([#120](#120)) ([126aeac](126aeac))
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with a small hook to extract as much of the caching as
possible.
Also fixes a test suite setup.
Signed-off-by: Patrik Kullman [email protected]