feat: extend error message details

[dotpointer]

Extend error message details so they tell more about what the error is about.

• Tell the idPath that is being used, a common cause of error is a misconfigured idPath (id-path).

• Tell the list data, a cause of error is an empty list or one that does not have the expected data.

• Reformat the id and item data presentation so it explains what these are.

No issue.

[megheaiulian]

Tests are failling ...

[dotpointer]

Tests are failling ...

Tried replacing calledWithExactly with calledWithMatch in the tests since the log messages now contains objects. But the tests fail anyway.

How do I get the warn outputs that the spies compares with and how do I use calledWithMatch - I thought it wanted partial regular expressions?

[cristinecula]

@dotpointer calledWithMatch works with a sinon matcher: https://sinonjs.org/releases/latest/matchers/

[dotpointer]

@dotpointer calledWithMatch works with a sinon matcher: https://sinonjs.org/releases/latest/matchers/

Something like this?
assert.isTrue(warnSpy.calledWithMatch(sinon.match.regexp('/regular expression/')), true);

Pushed a change to try it but it says sinon.match.regexp is not a function even if it imports /components/sinon/pkg/sinon.js?

[cristinecula]

@dotpointer the documentations says: sinon.match(regexp);, so it should be:
calledWithMatch(sinon.match(/List item...

[megheaiulian]

Try assert.isTrue(warnSpy.calledWithMatch(sinon.match(/regular\sexpression/iu)), true);

[dotpointer]

Try assert.isTrue(warnSpy.calledWithMatch(sinon.match(/regular\sexpression/iu)), true);

Pushed a fix with it now.

[dotpointer]

@cristinecula @megheaiulian Still failing, also tried this to match anything without progress:

const warnSpy = sinon.spy(console, 'warn'),
    data = { id: 23 };
nav.setItemById('23', data);
assert.isTrue(warnSpy.calledWithMatch(sinon.match('/.*/iu')), true);
warnSpy.restore();

It finds false and also outputs Attempted to wrap warn which is already wrapped.

[cristinecula]

@dotpointer '/.*/iu' is not a regex, it's a string. Remove the quotes.

[dotpointer]

@dotpointer '/.*/iu' is not a regex, it's a string. Remove the quotes.

Tried assert.isTrue(warnSpy.calledWithMatch(sinon.match(/.*/iu)), true);, but it fails the same. Updated the tests.

[megheaiulian]

This was wrong because console.warn() was called with multiple arguments ...

[dotpointer]

This was wrong because console.warn() was called with multiple arguments ...

Not sure that I understand here, console.warn() can take multiple arguments like console.log() do?

[cristinecula]

@dotpointer warn was called with multiple arguments, but the tests were asserting that it was called with a single argument.

[dotpointer]

Aha, thanks.

[github-actions]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀