selectedInstance not tracking instance on realign #106
Comments
nomego
pushed a commit
that referenced
this issue
Jan 8, 2020
* fix: refactor selectedInstance and selectedElement notification * chore: update deps * chore: update commitlint version * chore: force ci fixes #106
github-actions bot
pushed a commit
that referenced
this issue
Jan 8, 2020
## [3.0.7](v3.0.6...v3.0.7) (2020-01-08) ### Bug Fixes * refactor selectedInstance and selectedElement notification ([c655e56](c655e56)), closes [#106](#106)
|
🎉 This issue has been resolved in version 3.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In frontend, we use selectedInstance to observe when data-nav is navigating among the items and after change, call syncImageState on the new instance, causing it to sync with the external window (if available) to make it a seamless transition between items.
However, when removing an item from the items list, we call realignElements that will splice _elements and cause selectedInstance to update, but for some reason selectedInstance gets set to the removed instance, causing the syncImageState to fail.
Manipulated the
selectedproperty will make data-nav sync up again and correctly recalculate selected elements and instances.The text was updated successfully, but these errors were encountered: