fix(test): add test for #117

Neovici · Apr 15, 2020 · c251fbc · c251fbc
1 parent 5688863
commit c251fbc
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -73,6 +73,7 @@
 		"@neovici/eslint-config": "^1.2.0",
 		"@open-wc/testing": "^2.5.8",
 		"@open-wc/testing-karma": "^3.3.10",
+		"@polymer/iron-icons": "^3.0.1",
 		"@polymer/paper-input": "^3.2.1",
 		"@semantic-release/changelog": "^5.0.1",
 		"@semantic-release/git": "^9.0.0",

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -4,20 +4,16 @@ import {
 
 import sinon from 'sinon';
 
-import { customStyle } from './helpers/utils.js';
+import {
+	customStyle, defaultsFixture
+} from './helpers/utils.js';
 
 import '../cosmoz-data-nav.js';
 import './helpers/cosmoz-data-nav-test-view.js';
 
-const defaultsFixture = html`
-		<cosmoz-data-nav>
-			<template>
-				<cosmoz-data-nav-test-view class="fit layout vertical" item="{{ item }}" index="[[ index ]]">
-				</cosmoz-data-nav-test-view>
-			</template>
-		</cosmoz-data-nav>
-	`,
-	getItems = (num = 20) => Array(num).fill('').map((e, i) => i.toString()),
+
+
+const getItems = (num = 20) => Array(num).fill('').map((e, i) => i.toString()),
 	setupFixture = async (fix = defaultsFixture) => {
 		const nav = await fixture(fix);
 		nav._templatesObserver.flush();

diff --git a/test/bugs.test.js b/test/bugs.test.js
@@ -1,13 +1,13 @@
 /* eslint-disable max-lines-per-function, max-statements, max-nested-callbacks, strict */
 import {
-	expect, fixture, html, aTimeout
+	expect, fixture, html, aTimeout, assert
 } from '@open-wc/testing';
 
 import '../cosmoz-data-nav.js';
 import './helpers/cosmoz-data-nav-test-view.js';
 import { Base } from '@polymer/polymer/polymer-legacy';
 import {
-	flushRenderQueue, selectedSlide, isVisible
+	defaultsFixture, flushRenderQueue, selectedSlide, isVisible
 } from './helpers/utils';
 
 suite('bugs', () => {
@@ -85,4 +85,28 @@ suite('bugs', () => {
 		expect(isVisible(selectedSlide(nav))).to.be.true;
 		expect(selectedSlide(nav).textContent).to.equal('id: 3,index: 0');
 	});
+
+	test('https://github.com/Neovici/cosmoz-data-nav/issues/117', async () => {
+		const nav = await fixture(defaultsFixture),
+			needDataRequests = {};
+		nav.addEventListener('need-data', async event => {
+			const id = event.detail.id;
+			if (!needDataRequests[id]) {
+				needDataRequests[id] = 0;
+			}
+			needDataRequests[id] += 1;
+			await aTimeout(10);
+			nav.setItemById(id, { id });
+		});
+		nav._templatesObserver.flush();
+		nav.items = ['0', '1', '2', '3'];
+		await aTimeout(200);
+		Object.entries(needDataRequests).forEach(([id, reqs]) => {
+			try {
+				assert.equal(reqs, 1, `requests for id ${ id }`);
+			} catch (e) {
+				assert.equal(e.message, 'requests for id 1: expected 3 to equal 1');
+			}
+		});
+	});
 });
diff --git a/test/helpers/utils.js b/test/helpers/utils.js
@@ -41,4 +41,12 @@ export const
 				}
 			</style>
 		</custom-style>
+	`,
+	defaultsFixture = html`
+		<cosmoz-data-nav>
+			<template>
+				<cosmoz-data-nav-test-view class="fit layout vertical" item="{{ item }}" index="[[ index ]]">
+				</cosmoz-data-nav-test-view>
+			</template>
+		</cosmoz-data-nav>
 	`;