Skip to content

Commit

Permalink
fix(test): drop selectedInstance bug tests 🎉
Browse files Browse the repository at this point in the history
Signed-off-by: Patrik Kullman <[email protected]>
  • Loading branch information
Patrik Kullman authored and cristinecula committed Jun 17, 2020
1 parent 30d7a93 commit 2ff6a26
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
9 changes: 1 addition & 8 deletions test/bugs.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,8 @@ suite('bugs', () => {
nav.setItemById('0', { id: '0' });
nav.setItemById('1', { id: '1' });
flushRenderQueue(nav);
let bug = false;
try {
assert.isOk(nav.selectedInstance);
} catch (e) {
assert.equal(e.message, 'expected undefined to be truthy');
bug = true;
}
assert.isOk(nav.selectedInstance);
nav.selected = 1;
assert.isOk(nav.selectedInstance);
assert.isTrue(bug, 'bug fixed?');
});
});
7 changes: 2 additions & 5 deletions test/spec.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,11 +346,8 @@ suite('properties', () => {
});

suite('selectedInstance', () => {
test('exposes the instance of the selected item');
test('does not work properly [KNOWN BUG]', () => {
expect(() => {
expect(nav.selectedInstance).to.exist;
}).throws('expected undefined to exist');
test('exposes the instance of the selected item', () => {
expect(nav.selectedInstance).to.exist;
});
});

Expand Down

0 comments on commit 2ff6a26

Please sign in to comment.