fix: drop old comment and notifyProp prop, rename visibility fixture

Signed-off-by: Patrik Kullman <[email protected]>
Neovici · Apr 15, 2020 · 111e122 · 111e122
1 parent 05d4662
commit 111e122
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 17 deletions.
diff --git a/cosmoz-data-nav.js b/cosmoz-data-nav.js
@@ -760,7 +760,6 @@ class CosmozDataNav extends translatable(mixinBehaviors([IronResizableBehavior],
 		if (selectedElement == null) {
 			return;
 		}
-		// index 0 is incomplete element
 		return selectedElement.children[0];
 	}
 

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -5,7 +5,7 @@ import {
 import sinon from 'sinon';
 
 import {
-	customStyle, defaultsFixture, flushRenderQueue, getItems, setupFixture
+	visibilityFixture, defaultsFixture, flushRenderQueue, getItems, setupFixture
 } from './helpers/utils.js';
 
 import '../cosmoz-data-nav.js';
@@ -351,7 +351,7 @@ suite('renderQueue', () => {
 
 	setup(async () => {
 		[, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			setupFixture(html`
 				<cosmoz-data-nav elements-buffer="5">
 					<template>

diff --git a/test/bugs.test.js b/test/bugs.test.js
@@ -7,7 +7,7 @@ import '../cosmoz-data-nav.js';
 import './helpers/cosmoz-data-nav-test-view.js';
 import { Base } from '@polymer/polymer/polymer-legacy';
 import {
-	customStyle, defaultsFixture, flushRenderQueue, selectedSlide, isVisible, setupFixture
+	visibilityFixture, defaultsFixture, flushRenderQueue, selectedSlide, isVisible, setupFixture
 } from './helpers/utils';
 
 const oneRequestPerItem = async nav => {
@@ -130,7 +130,7 @@ suite('bugs', () => {
 
 	test('selected instance not set', async () => {
 		const [, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			await setupFixture()
 		]);
 		nav.setItemById('0', { id: '0' });

diff --git a/test/helpers/utils.js b/test/helpers/utils.js
@@ -28,16 +28,11 @@ export const
 				},
 				nextDisabled: {
 					type: Boolean
-				},
-				notifyProp: {
-					type: Boolean,
-					notify: true,
-					value: false
 				}
 			};
 		}
 	},
-	customStyle = html`
+	visibilityFixture = html`
 		<custom-style>
 			<style include="iron-flex iron-positioning">
 				cosmoz-data-nav {

diff --git a/test/resizable.test.js b/test/resizable.test.js
@@ -4,7 +4,7 @@ import {
 
 import sinon from 'sinon';
 
-import { customStyle } from './helpers/utils.js';
+import { visibilityFixture } from './helpers/utils.js';
 
 import '../cosmoz-data-nav.js';
 import './helpers/cosmoz-data-nav-resizable-view.js';
@@ -30,7 +30,7 @@ suite('resizable', () => {
 
 	suiteSetup(async () => {
 		[, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			fixture(html`
 				<cosmoz-data-nav>
 					<template>

diff --git a/test/spec.test.js b/test/spec.test.js
@@ -5,7 +5,7 @@ import {
 import '../cosmoz-data-nav.js';
 import './helpers/cosmoz-data-nav-test-view.js';
 import {
-	flushRenderQueue, selectedSlide, customStyle
+	flushRenderQueue, selectedSlide, visibilityFixture
 } from './helpers/utils';
 import { flush as syncFlush } from '@polymer/polymer/lib/utils/flush';
 
@@ -37,7 +37,7 @@ suite('constructor', () => {
 suite('template', () => {
 	test('renders items using a template', async () => {
 		const [, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			fixture(basicFixture)
 		]);
 		nav._templatesObserver.flush();
@@ -51,7 +51,7 @@ suite('template', () => {
 	test('renders the wrong item if the templates observer runs after `items` is set [KNOWN BUG]', async () => {
 		//expect(async () => {
 		const [, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			fixture(basicFixture)
 		]);
 		nav.items = [{ id: 1 }, { id: 2 }, { id: 3 }];
@@ -70,7 +70,7 @@ suite('properties', () => {
 	let nav;
 	setup(async () => {
 		[, nav] = await Promise.all([
-			fixture(customStyle),
+			fixture(visibilityFixture),
 			fixture(basicFixture)
 		]);
 		nav._templatesObserver.flush();
-Original file line number
+Diff line change
@@ Expand Up @@
     		if (selectedElement == null) {
     			return;
     		}
-    		// index 0 is incomplete element
     		return selectedElement.children[0];
     	}
@@ Expand Down @@