BUGFIX: LinkEditor placeholder now uses the custom placeholder correctly
#3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly Initially the user could set a placeholder, but inside the `LinkInput.js` it wouldn't be used and an unnecessary static placeholder would be used instead Fixes neos#3797
grebaldi
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Hi @dr-format-d,
thanks a lot for your first PR to the Neos UI! 🎉
I tested your change and it makes custom placeholders work correctly. However, I'll need a little adjustment (see comment below), so that it still works, when no custom placeholder is configured.
…r on empty `placeholder:` setting If someone leaves the `placeholder:` setting empty, the default placeholder, instead of a completely empty `LinkEditor`-input will be shown. Fixes neos#3797
grebaldi
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3797
What I did
If the user now sets a placeholder for the
LinkEditorthe placeholder will now be correctly shown in the neos frontend.How I did it
I removed a (imo) unnecessary condition, which caused the custom placeholder to be always overridden with a static placeholder.
How to verify it
Try to set a placeholder for the
LinkEditorlike you would/expect with any other editor componentBefore:
After:
