Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Disable node text selection in document tree #3747

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

Alvadda
Copy link
Collaborator

@Alvadda Alvadda commented Mar 13, 2024

It was possible to select the HTML Text from the node elements in the documentation tree via shift + left click.
This bug was found in the PR 3625 via the commit

The issue arrived premier in the safari browser.

The issue was fixed be applying user-select: none to the whole tree element to prevent all children to be HTML text selectable.

To verify this, try to select multiple elements with shift + left click and there should not have the default blue selection highlight.

Wrong:

Correct:
image

@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.3 labels Mar 13, 2024
@Alvadda Alvadda marked this pull request as draft March 13, 2024 17:36
@Alvadda Alvadda changed the base branch from 8.3 to 8.4 March 13, 2024 17:41
@github-actions github-actions bot added 8.4 and removed 8.3 labels Mar 13, 2024
@Alvadda Alvadda marked this pull request as ready for review March 13, 2024 18:04
esbuild.js Show resolved Hide resolved
@Alvadda Alvadda changed the base branch from 8.4 to 8.3 March 14, 2024 10:35
@github-actions github-actions bot added 8.3 and removed 8.4 labels Mar 14, 2024
@Alvadda Alvadda force-pushed the bugfix/disableTextSelectionInDocumentTree branch from 4f1fe2c to 0602955 Compare March 14, 2024 10:58
@ahaeslich ahaeslich requested a review from mhsdesign March 14, 2024 14:17
@ahaeslich
Copy link
Member

➕ by 👀

@ahaeslich ahaeslich requested review from grebaldi and Sebobo March 15, 2024 15:38
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. it works on my mashine as well

@mhsdesign mhsdesign merged commit cf41c70 into neos:8.3 Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants