BUGFIX SpeedUp Inspector Title E2E Test #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously do to some automatic magic tescafe would wait before clicking into the iframe because the unappliedChangesOverlay is already in the dom and this warning is shown:
> TestCafe cannot interact with the <iframe name="neos-content-main"> element because another element obstructs it.
When something overlaps the action target, TestCafe performs the action with the topmost element at the original target's location.
The following element with a greater z-order replaced the original action target: <div class="unappliedChangesOverlay">.
Review your code to prevent this behavior.
This waiting results in a super slow down of multiple seconds!
To fix this we dont attempt to click directly in the iframe via selector but we use click left to the inspector (via negative offset) that allows to trick tescafe.
Alternative options are possibly to use a ClientFunction, absolute coordinate clicking (doesnt seem possible with testcafe) or adding a timeout `Selector('iframe', {timeout: 200})` to the selector, which would still cause the warning to dispatch though.
grebaldi
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Hi @mhsdesign,
makes total sense. I wouldn't even call that a hack, since the whole purpose of the unapplied changes overlay is to obstruct the <iframe/>, which is duely recognized by test café :)
I read your change as "click somewhere in the general area where the guest frame should be, expect it to be obstructed and to trigger the unapplied changes dialog".
So, overall this LGTM 👍
markusguenther
approved these changes
Jan 15, 2024
| .click(Selector('#neos-UnappliedChangesDialog-apply')) | ||
| .expect(InspectorTitleProperty.value) | ||
| .eql('Home-1-3') | ||
| .click(Selector('[name="neos-content-main"]')) | ||
| .click(Selector('#neos-Inspector'), {offsetX: -400}) // hack to click into the iframe even with overlaying changes div in dom |
There was a problem hiding this comment.
In a worst-case screen size, it can happen that you click the left sidebar instead of the content canvas.
There was a problem hiding this comment.
yes and that still would trigger the overlay ^^ also the tests are run in a fixed window sized :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously do to some automatic magic tescafe would wait before clicking into the iframe because the unappliedChangesOverlay is already in the dom and this warning is shown:
This waiting results in a super slow down of multiple seconds! To fix this we dont attempt to click directly in the iframe via selector but we use click left to the inspector (via negative offset) that allows to trick tescafe.
Alternative options are possibly to use a ClientFunction, absolute coordinate clicking (doesnt seem possible with testcafe) or adding a timeout
Selector('iframe', {timeout: 200})to the selector, which would still cause the warning to dispatch though.What I did
How I did it
How to verify it