Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Overlay / stacked dialog issue with Sitegeist.Archaeopteryx Editor #3583

Closed
crydotsnake opened this issue Jul 27, 2023 · 8 comments
Closed
Labels
8.3 Bug Label to mark the change as bugfix

Comments

@crydotsnake
Copy link
Member

Description

When creating a link with the Sitegeist.Archaeopteryx Editor the Link overlay from the editor is stacked under the UI overlay. But the link overlay should be displayed first.

Steps to Reproduce

  1. Install (https://github.com/sitegeist/Sitegeist.Archaeopteryx)
  2. Adjust your NodeType for example the TextWithImage NodeType:
    link:
      type: string
      ui:
        label: Link
        showInCreationDialog: true
        help:
          message: 'Create a link'
        inspector:
          editor: 'Sitegeist.Archaeopteryx/Inspector/Editors/LinkEditor'
  1. Try too create a link.

Expected behavior

The overlay of from the Archaeopteryx editor should be at the first.

Actual behavior

The link overlay from the Archaeopteryx gets stacked under the UI overlay

neos-ui-overlay.mov

[What actually happened]

Affected Versions

Neos: 8.3

UI: 8.3.3

You can get this information by running composer show or using the package management module within Neos.
The UI version can also be found inside the left sidebar after version 1.0.3.

@crydotsnake crydotsnake added Bug Label to mark the change as bugfix 8.3 labels Jul 27, 2023
@crydotsnake
Copy link
Member Author

I'm not sure if this is related too #2925 ? @grebaldi @mhsdesign @Sebobo Or if this even has something to do with the UI, or if this is a bug related in the Sitegeist.Archaeopteryx Editor package.

Also I'm very sorry for the bad description. But i wasnt really sure how i could describe this better.

@mhsdesign
Copy link
Member

Might be a regression from #3492 ... which was released with 8.3.3.

Does this problem occur also with 8.3.2?

@crydotsnake
Copy link
Member Author

Does this problem occur also with 8.3.2?

Could reproduce it with the UI Versions: 8.3.3, 8.3.2, and 8.3.1. In 8.3.0 it works as usual.

@grebaldi
Copy link
Contributor

Yes, there were some changes on z-indices that may affect that dialog. If so, this needs to be fixed in Sitegeist.Archaeopteryx though.

@nezaniel
Copy link
Member

I can confirm this with Sitegeist.InspectorGadget in Neos 9

@crydotsnake
Copy link
Member Author

Mhh. Is it then really related to the UI, or in the packages itself?

@grebaldi
Copy link
Contributor

grebaldi commented Jul 28, 2023

I'll take a look at both, Sitegeist.Archaeopteryx and Sitegeist.InspectorGadget, and see if I can come up with a fix.

EDIT: @crydotsnake:

Is it then really related to the UI, or in the packages itself?

IIRC Sitegeist.Archaeopteryx and Sitegeist.InspectorGadget both have custom dialog implementations which may very well collide with the z-index changes in the UI. The problem is therefore very likely fixable in those packages.

@crydotsnake
Copy link
Member Author

Okay. Then i will close this issue since it is related too the packages. I will create the same issue as in Sitegeist.Archaeopteryx in Sitegeist.InspectorGadget too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

4 participants