Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call emulated: PaymentSplitter.rejects an empty set of payees #299

Closed
rozhkovdmitrii opened this issue Nov 17, 2021 · 2 comments · Fixed by #368
Closed

Call emulated: PaymentSplitter.rejects an empty set of payees #299

rozhkovdmitrii opened this issue Nov 17, 2021 · 2 comments · Fixed by #368
Assignees

Comments

@rozhkovdmitrii
Copy link
Contributor

rozhkovdmitrii commented Nov 17, 2021

STR:

It can be reproduced either manually with open zeppelin testing like that:

$ truffle test test/finance/PaymentSplitter.test.js --network solana

Expected result:

  1. Contract: PaymentSplitter
    rejects an empty set of payees:

PaymentSplitter in particular and neon evm endpoint should raise the error "PaymentSplitter: no payees"

Actual result:

"execution reverted"

emulate_call on proxy gets "revert" exit status and returns wrong result

Full output:

Contract: PaymentSplitter
@openzeppelin/test-helpers WARN expectRevert: Assertions may yield false negatives!

Revert reason checks are only known to work on Ganache >=2.2.0 and Hardhat, and the current node is Neon/v0.3.0-rc1-a3a3cee.

If your node does support revert reasons, please let us know: https://github.com/OpenZeppelin/openzeppelin-test-helpers/issues/new
    1) rejects an empty set of payees
    2) "after each" hook: after test for "rejects an empty set of payees"


  0 passing (2s)
  2 failing

  1) Contract: PaymentSplitter
       rejects an empty set of payees:

      Wrong kind of exception received
      + expected - actual

      -execution reverted
      +PaymentSplitter: no payees
       
      at expectException (node_modules/@openzeppelin/test-helpers/src/expectRevert.js:20:30)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at expectRevert (node_modules/@openzeppelin/test-helpers/src/expectRevert.js:75:3)
      at Context.<anonymous> (test/finance/PaymentSplitter.test.js:15:5)

  2) Contract: PaymentSplitter
       "after each" hook: after test for "rejects an empty set of payees":
     Error: syntax error at or near ")"
LINE 1: ... blockNumber >= 2657 AND blockNumber <= 2657 AND topic IN ()
                                                                      ^

      at /home/rozhkov/sources/oz/node_modules/@trufflesuite/web3-provider-engine/subproviders/provider.js:18:36
      at XMLHttpRequest.request.onreadystatechange (node_modules/web3-providers-http/lib/index.js:98:13)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/xhr2-cookies/xml-http-request-event-target.ts:44:13)
      at XMLHttpRequest._setReadyState (node_modules/xhr2-cookies/xml-http-request.ts:219:8)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/xhr2-cookies/xml-http-request.ts:345:8)
      at IncomingMessage.<anonymous> (node_modules/xhr2-cookies/xml-http-request.ts:311:39)
      at IncomingMessage.emit (node:events:402:35)
      at endReadableNT (node:internal/streams/readable:1343:12)
      at processTicksAndRejections (node:internal/process/task_queues:83:21)
@rozhkovdmitrii rozhkovdmitrii self-assigned this Nov 17, 2021
@rozhkovdmitrii rozhkovdmitrii changed the title Call emulated: wrong result structure on revert exit_status Call emulated: PaymentSplitter.rejects an empty set of payees Nov 18, 2021
@rozhkovdmitrii
Copy link
Contributor Author

connected with #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants