Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pg_jsonschema and pg_graphql #3677

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix pg_jsonschema and pg_graphql #3677

merged 1 commit into from
Feb 23, 2023

Conversation

vadim2404
Copy link
Contributor

@vadim2404 vadim2404 commented Feb 22, 2023

Describe your changes

To avoid this error
image

Issue ticket number and link

Refers: #3535 pgcentralfoundation/pgrx#1056

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

@hlinnaka
Copy link
Contributor

I wonder why those extensions set superuser=false in the first place. superuser=true is the default, and it seems correct for those extensions.

@vadim2404
Copy link
Contributor Author

I wonder why those extensions set superuser=false in the first place. superuser=true is the default, and it seems correct for those extensions.

It's because of the template in cargo-pgx

❯ cargo pgx new xxx
❯ cd xxx
❯ ls
Cargo.toml  sql         src         xxx.control
❯ cat xxx.control
comment = 'xxx:  Created by pgx'
default_version = '@CARGO_VERSION@'
module_pathname = '$libdir/xxx'
relocatable = false
superuser = false

@vadim2404 vadim2404 merged commit 5ebf7e5 into main Feb 23, 2023
@vadim2404 vadim2404 deleted the vk/fix_pgx_extensions branch February 23, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants